Merged
Conversation
Contributor
nikita-seedlabs
commented
Mar 18, 2026
nikita-seedlabs
commented
- Add makefile with an option of running openapi generator in docker
- Add alternative packageVersion python script to bump semver versions without running apigen
- Split out shared auth openapi models
- Clean up old generated code
add makefile docker utils, clean up old openapi generated files
nikita-seedlabs
requested review from
a team,
alawrenc and
lucasfronza
as code owners
alawrenc
previously approved these changes
Mar 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the auth OpenAPI spec to split shared auth schemas into a separate document, adds local tooling to run OpenAPI generation via Docker, and introduces a script to bump SDK versions based on detected spec changes while cleaning up previously generated Rust artifacts.
Changes:
- Added a Docker-based
Makefileworkflow for generating TS/Python/Rust SDKs and bumping versions. - Introduced
scripts/version_bump.pyto detect spec changes via hashing and bump versions across generator configs/manifests. - Split shared auth schemas into
resources/auth-common.yaml, updatedresources/auth-api.yamlrefs accordingly, and removed obsolete generated Rust models/docs.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/sdk/src/.openapi-generator-ignore | Ignore additional hand-written TS SDK files to prevent generator overwrites. |
| scripts/version_bump.py | New spec-hash-based version bump utility for generator configs and package manifests. |
| rust/gen/bluefin_api/src/models/post_create_order_202_response.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/src/models/ping_response.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/src/models/ping_request.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/src/models/get_rewards_interval_metadata_interval_parameter.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/src/models/create_order_request_twap_config.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/src/models/campaign_rewards.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/src/models/affiliate_metadata_fees.rs | Removed obsolete generated Rust model. |
| rust/gen/bluefin_api/docs/PostCreateOrder202Response.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/docs/PingResponse.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/docs/PingRequest.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/docs/GetRewardsIntervalMetadataIntervalParameter.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/docs/CreateOrderRequestTwapConfig.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/docs/CampaignRewards.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/docs/AffiliateMetadataFees.md | Removed obsolete generated Rust docs. |
| rust/gen/bluefin_api/.openapi-generator/FILES | Updated generator file tracking to include .openapi-generator-ignore. |
| resources/auth-common.yaml | New shared auth component schemas/responses extracted from auth spec. |
| resources/auth-api.yaml | Updated to reference shared components via external $ref to auth-common.yaml. |
| python/sdk/src/.openapi-generator-ignore | Ignore additional hand-written Python SDK files/dirs to prevent generator overwrites. |
| Makefile | New Docker-based OpenAPI generation and version-bump targets. |
| .gitignore | Ignore additional editor/OS artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alawrenc
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.